generated from NOAA-OWP/owp-open-source-project-template
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update style to more modern python idioms and remove dead imports #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaraney
added
ngen.config
Related to ngen.config package
ngen.cal
Related to ngen.cal package
ngen.init_config
Related to ngen.init_config package
ngen.config_gen
Related to ngen.config_gen package
labels
Aug 6, 2024
aaraney
force-pushed
the
style-updates
branch
2 times, most recently
from
August 6, 2024 21:05
53e8817
to
62370dc
Compare
hellkite500
reviewed
Aug 14, 2024
aaraney
force-pushed
the
style-updates
branch
4 times, most recently
from
August 14, 2024 17:41
62370dc
to
0189079
Compare
@hellkite500, I think we should be good to merge this now. |
hellkite500
previously approved these changes
Aug 15, 2024
aaraney
requested review from
hellkite500
and removed request for
robertbartel
August 15, 2024 17:18
hellkite500
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ngen.cal
Related to ngen.cal package
ngen.config_gen
Related to ngen.config_gen package
ngen.config
Related to ngen.config package
ngen.init_config
Related to ngen.init_config package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does introduce behavioral changes. Its highly recommended to view each commit individually during review. Ive split things up by the refactoring / stylistic operation that was performed to make this easier to review.
The refactors / stylistic improvements performed are:
chore:
from __future__ import annotations
to relevant filesrefactor:
typing.TYPE_CHECKING
typing.Union
style:
__future__
annotations
and remove quotes from, now, non-runtime type hintsf
-stringsNote: non-
typing
types (e.g.list[str]
) do not work withpydantic
forpython<=3.8
. See this issue for more information.